Mockups are having a little renaissance. They're so much better than they used to be, but awful ones still abound. Here are my top recommendations to present your work in the best light:
For photography, start with The Brand Identity's mockup store. It's an aggregation of some of the best mockups, including those featured individually below. Fantastic quality and broadly usable (not too opinionated, so the emphasis is on the work and they're flexible) with a medium price point in my opinion. Check out the heavily-discounted bundles.
LS Graphics is my go-to for isolated device renders, both static (PS) animated (AE). A wide array of devices and platforms. Buy ala carte or in an unlimited-access subscription (a great value). They also have a fantastic Figma plugin with a subset of their products available as a (confusingly, different) subscription, which is highly recommended. A bunch of equally high quality free stuff, too.
Mockups Directory has great minimal imagery with a very polished feel. Mostly devices held in minimalist environments but also some print. Free stuff, too.
Mockup Maison has a huge library of photographed mockups across a wide array of cities worldwide. Particularly good for city-specific outdoor signage (especially billboard and subway ad placements), clothing, and print generally, all with artful shadows and a realistic, trendy feel. Some devices available, too. Expensive, individually and especially in a $1.3k/year subscription, but you get what you pay for with this.
Bendito Mockup, based out of Spain, is similar. Lifestyle photography is grouped in photoshoots, each with a consistent feel all their own. Particularly great at capturing a certain kind of cool, trendy, fashion-y, modern millennial/gen-z lifestyle vibe. As with a lot of lifestyle photography, heavy emphasis on print (which is also much more evergreen than devices). Great value—very fairly priced.
Art Directed (ARTD) is also similar to the photo ones above. IRL photography in a style that I think is really versatile.
Mockup Republic is another fantastic one. Photography with a great mood, but a pretty small collection so far.
Akoya Studio has a bunch of nice photography-based mockups. Minimalist and modern.
Beyond Forms is a gorgeous mockup project by the very talented Daniel Lepik. Also a tiny collection so far.
099's Minimal Mockups all have a single aesthetic: single devices, packaging, and merch on a granite-esque cube. You can customize the lighting, angle, device color, etc. before purchasing. Interestingly, the site's name comes from the commitment to having only 99 products (though each have variations) in the catalog; items will be archived to make room for new, better things.
Mr. Mockup can be a solid option. Great scene composition packs for branding, especially food packaging. Straightforward and very affordable.
Mockuuups Studio is a web-based drag-and-drop dead-simple tool. Some of them can work but not nearly at the quality of the other options here—runs a bit stock-image-y.
Maneken is a new app that combines high-quality imagery with a super convenient webapp that will apply your designs automatically
Ply has some nice mockups straddling renders and photography, with a futuristic vibe.
Peculiar Mockups is just what it says on the tin—mockups that are a bit weird